Strange results with solar envelope component !!

Replies to This Discussion

Permalink Reply by Chris Mackey on August 20, 2015 at 9:49pm

Khaoula,

I can't say what is going wrong in your case but we are discontinuing this solar envelope (that relied on McNeil's buggy boolean intersect operation) now that our awesome developer Boris has produced a much more advanced one.  You should sync with the github to get Boris's component and you should check out this example file here to see how to use it:

https://app.box.com/s/aormi5g1n9cs47brhmrz1hqnf5rr0lul

Also, to understand the rigor of testing that Boris's solar envelope has passed through, you should see this github issue that is long enough to be a short story:

https://github.com/mostaphaRoudsari/ladybug/issues/161

-Chris

Permalink Reply by khaoula on September 10, 2015 at 6:13am

Thanks for your response,

I was making up my mind on this problem!

there is always a missing point (hour) when i use the time period component.  I think maybe there is a problem with this component and there is a missing +1 in the period calculation.

I don't Know !!

Permalink Reply by Chris Mackey on September 13, 2015 at 3:56pm

Khaoula,

I would not say that this is a problem with the analysis period component but it is definitely an indication that the sunpath has a different interpretation of the analysis period than the other Ladybug components.  In one sense, I can see that it might be confusing  if an analysis period from 10 to 14 gave you 5 hours of data instead of 4 (since you might expect 14-10=4).  However, all of the other ladybug components would give you the 5 hours of data for this type of analysis period and I feel that, for the sake of consistency with the other Ladybug components, you are right that you should get 5 sun vectors out for this type of analysis period.  If Mostapha agrees, I will change this in the sunpath component.

-Chris

Permalink Reply by Mostapha Sadeghipour Roudsari on September 22, 2015 at 4:42pm

Hi Chris and Khaoula. It is intentional and it matches how Daysim defines hours. Imagine when you say people work from 8-5, it means they will leave at 5 so 5-6 won't be part of the analysis period which is why you don't get the last sun. At the same time I totally agree that it's not what you expect to happen.

Mostapha

Permalink Reply by khaoula on September 23, 2015 at 5:04am

Ok thanks for your response

it is clear for me now 

Khaoula